EPMGCIP-179: Configure linters #31
Conversation
…operties, update max warnings to 30
lint-staged.config.mjs
Outdated
| @@ -1,5 +1,5 @@ | |||
| const config = { | |||
| '*.{js,jsx,ts,tsx}': ['eslint --fix --max-warnings 100', 'prettier --write'], | |||
| '*.{js,jsx,ts,tsx}': ['eslint --fix --max-warnings 30', 'prettier --write'], | |||
There was a problem hiding this comment.
@Dzmitry-Yaniuk
What do you think about decreasing warnings to '0'? It was '0' before switching to nextjs, so I guess we can try to continue doing that.
There was a problem hiding this comment.
Good idea! From my opinion absence of warnings in code is a project good shape indicator.
However, with existing applied rules we get already around 10 warnings, refactoring code in terms of this PR might not be a good idea. Perhaps I can set this limit now to 20 items?
Otherwise code cannot be pushed without bypass option for git commit.
.eslintrc.json
Outdated
| "next/core-web-vitals", | ||
| "eslint:recommended", | ||
| "prettier", | ||
| "plugin:@typescript-eslint/recommended" |
There was a problem hiding this comment.
Previously we also used this plugins:
'plugin:jest/recommended',
'plugin:react-hooks/recommended',
'airbnb',
'airbnb/hooks',
'airbnb-typescript'
Maybe there is a sense to add them as well. What do you think about that?
There was a problem hiding this comment.
Since there are existing eslint:recommended and prettier plugins I assume airbnb related plugins might be a little redundant (quite rules in common). What do you think?
…ate usage in test to resolve warning
https://jira.epam.com/jira/browse/EPMGCIP-179
Code changes
.gitignoreto exclude MS and JetBrains IDE working settings;.eslint.jsonfile with multiple rules ESLint rules for TypeScript, JavaScript and React;.prettierignorefile with folders to exclude some directories from checking for Prettier;messagesfolder intsconfig.json;Notes